This repository has been archived by the owner on Sep 20, 2024. It is now read-only.
Ftrack subprocess handle of stdout/stderr #1675
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iLLiCiTiT
requested review from
64qam,
antirotor,
jakubjezek001,
kalisp and
mkolar
14 tasks
64qam
approved these changes
Jun 11, 2021
|
have tried it on |
jakubjezek001
approved these changes
Jun 11, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
Ftrack user event server is running as subprocess which cause issues with logging because all python subprocess.Popen objects have stdout and stderr which are inherited from source process, but if
openpype_guiexecutable is used then sys.stdout and sys.stderr are set to None so new created processes get strange PIPE objects that can't work withPypeStreamHandlerproperly and may crash at any time becauseflushof the stream cause OSError.Changes
Why is that important
Any processed action can crash during logging (most visible when launchin application).
How to replicate issue
Hard to say. I launched Nuke 5-10 timer in row from ftrack. One of launches should crash if
openpype_guiexecutable is used.Closes: https://github.com/pypeclub/client/issues/92